Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix openlineage tests #44025

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

gopidesupavan
Copy link
Member

Tests are failing https://github.com/apache/airflow/actions/runs/11837035818/job/32983342904?pr=44018#step:7:4873


^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named {pr_number}.significant.rst or {issue_number}.significant.rst, in newsfragments.

@gopidesupavan
Copy link
Member Author

gopidesupavan commented Nov 14, 2024

Not sure which PR causes this failure trying to find :)

@eladkal eladkal merged commit de15523 into apache:main Nov 14, 2024
18 checks passed
@gopidesupavan gopidesupavan deleted the fix-openlineage-tests branch November 14, 2024 13:12
@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

One of the few latest asset changes. I think we should automatically add providers open-lineage tests after any changes in assets, as their test heavily depend on them.

This will be quite a bit easier I think after #43979 lands.

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

Issue created : #44026

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

Yeah it was caused by #41325 - and there the test were green because openlineage tests were skipped by selective checks., so #44026 when implemented might help to avoid such breakages.

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

(or maybe @mobuchowski @kacpermuda - we could make those open-lineage tests less depending on actual dataset implementation ? Not sure).

@mobuchowski
Copy link
Contributor

The uri vs name thing is not purely implementation detail in this case. We actually try to serialize that information - the event output we want to have is depending on actual dataset specification - I'd rather do the opposite and run OL tests with any change to assets/datasets.

@mobuchowski
Copy link
Contributor

Oh yeah that's what you actually suggested within the issue :)

@potiuk
Copy link
Member

potiuk commented Nov 14, 2024

Oh yeah that's what you actually suggested within the issue :)

Yeah. I just wanted to check whether this is an accidental or REAL dependency on asset features.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants