Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enabling snapline plugin selecting and moving cells causes position errors #4490

Closed
wants to merge 1 commit into from

Conversation

wqgs2004214
Copy link

@wqgs2004214 wqgs2004214 commented Nov 1, 2024

Description

fix #4491

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…translateby是node2时,导致node2和组合在一起的node3移动错乱,并且node1移动错误的bug
@x6-bot
Copy link
Contributor

x6-bot bot commented Nov 1, 2024

👋 @wqgs2004214

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 1, 2024
@wqgs2004214 wqgs2004214 changed the title fix: Enabling Snapline plugin, selecting and moving cells causes position errors fix: Enabling Snapline plugin, selecting and moving cells causes position errors #4491 Nov 1, 2024
@wqgs2004214 wqgs2004214 changed the title fix: Enabling Snapline plugin, selecting and moving cells causes position errors #4491 fix: Enabling Snapline plugin, selecting and moving cells causes position errors Nov 1, 2024
@wqgs2004214 wqgs2004214 closed this Nov 1, 2024
@wqgs2004214 wqgs2004214 reopened this Nov 1, 2024
@wqgs2004214 wqgs2004214 changed the title fix: Enabling Snapline plugin, selecting and moving cells causes position errors fix: enabling snapline plugin, selecting and moving cells causes position errors Nov 1, 2024
@wqgs2004214 wqgs2004214 closed this Nov 1, 2024
@wqgs2004214 wqgs2004214 reopened this Nov 1, 2024
@wqgs2004214 wqgs2004214 closed this Nov 1, 2024
@wqgs2004214 wqgs2004214 changed the title fix: enabling snapline plugin, selecting and moving cells causes position errors fix: enabling snapline plugin selecting and moving cells causes position errors Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: unreviewed PR does not have any reviews. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

开启snapline后,框选移动BUG
1 participant