Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

源码阅读 #4392

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

源码阅读 #4392

wants to merge 23 commits into from

Conversation

yelikang
Copy link

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Aug 19, 2024
@x6-bot
Copy link
Contributor

x6-bot bot commented Aug 19, 2024

👋 @yelikang

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot
Copy link
Contributor

x6-bot bot commented Aug 19, 2024

@yelikang Please provide us with more info about this pull request title.

@x6-bot
Copy link
Contributor

x6-bot bot commented Aug 19, 2024

@yelikang Please provide us with more info about this pull request.

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. pkg:x6 labels Aug 19, 2024
@yelikang yelikang marked this pull request as draft August 21, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-more-info pkg:x6 PR: unreviewed PR does not have any reviews. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant