Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Update get_mechanical_path #707

Merged
merged 7 commits into from
Apr 16, 2024
Merged

Feat: Update get_mechanical_path #707

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4fd8db5
pre-commit changes
dipinknair Apr 15, 2024
772c3bc
use updated get_mechanical
dipinknair Apr 16, 2024
ff55bf0
Merge branch 'main' into feat/get-mechanical
dipinknair Apr 16, 2024
5f4d0c2
Adding changelog entry: 707.added.md
pyansys-ci-bot Apr 16, 2024
6d6673b
no need of exe exception
dipinknair Apr 16, 2024
6231070
Merge branch 'main' into feat/get-mechanical
dipinknair Apr 16, 2024
8bc2180
test coverage
dipinknair Apr 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/changelog.d/707.added.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Feat: Update `get_mechanical_path`
12 changes: 2 additions & 10 deletions src/ansys/mechanical/core/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,16 +179,8 @@
if input_script:
raise Exception("Cannot open in server mode with an input script.")

if not revision:
exe = atp.get_mechanical_path() # check for saved mechanical path
if exe:
version = atp.version_from_path("mechanical", exe) # version is already int here
else:
exe, _version = atp.find_mechanical()
version = int(_version * 10)
else:
exe, _version = atp.find_mechanical(version=revision)
version = int(_version * 10)
exe = atp.get_mechanical_path(allow_input=False, version=revision)
version = atp.version_from_path("mechanical", exe)

Check warning on line 183 in src/ansys/mechanical/core/run.py

View check run for this annotation

Codecov / codecov/patch

src/ansys/mechanical/core/run.py#L182-L183 

Added lines #L182 - L183 were not covered by tests

version_name = atp.SUPPORTED_ANSYS_VERSIONS[version]

Expand Down
Loading