Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup #702

Merged
merged 4 commits into from
Apr 12, 2024
Merged

cleanup #702

merged 4 commits into from
Apr 12, 2024

Conversation

koubaa
Copy link
Collaborator

@koubaa koubaa commented Apr 12, 2024

minor code cleanup. I missed pushing it to the last branch

@koubaa koubaa requested a review from a team as a code owner April 12, 2024 15:55
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 12, 2024
Copy link
Collaborator

@klmcadams klmcadams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add docstrings to the functions?

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.80%. Comparing base (075583d) to head (7fd19f2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   76.90%   76.80%   -0.11%     
==========================================
  Files          31       31              
  Lines        1970     1970              
==========================================
- Hits         1515     1513       -2     
- Misses        455      457       +2     

@koubaa koubaa requested a review from klmcadams April 12, 2024 16:28
@koubaa koubaa merged commit c8dfd76 into main Apr 12, 2024
56 checks passed
@koubaa koubaa deleted the cleanup-open-usd branch April 12, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants