Support for different height on active bar #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some modifications on alwaysActive and areSelectedValuesDefault logic
anothem
requested changes
Nov 22, 2016
| @@ -116,6 +117,7 @@ | |||
| private int textSize; | |||
| private int distanceToTop; | |||
| private RectF rect; | |||
| private RectF rectActive; | |||
There was a problem hiding this comment.
I'm thinking that this doesn't need another rect on top of it, could be done with the one we have that's already drawing the line, just need to adapt its top and bottom when we draw it if it's active
| */ | ||
| private void drawThumb(float screenCoord, boolean pressed, Canvas canvas, boolean areSelectedValuesDefault) { | ||
| Bitmap buttonToDraw; | ||
| if (!activateOnDefaultValues && areSelectedValuesDefault) { | ||
| if (alwaysActive) { |
There was a problem hiding this comment.
Why did you need this? As far as I can tell, if the alwaysActive flag is on, the buttons never show as disabled
| @@ -26,6 +26,9 @@ | |||
| <!-- the height of the bar --> | |||
| <attr name="barHeight" format="dimension"/> | |||
|
|
|||
| <!-- the height of the active bar --> | |||
There was a problem hiding this comment.
This is good, but there should also be a way to set this in code
|
I removed the extra RectF object. Also I exposed both barHeight and activeBarHeight variables. Have a look :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modifications on alwaysActive and areSelectedValuesDefault logic