Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate SharedPreferences to DataStore #1180

Closed
wants to merge 1 commit into from
Closed

feat: Migrate SharedPreferences to DataStore #1180

wants to merge 1 commit into from

Conversation

Rohit-2602
Copy link

Description

Fixes #1177

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

I make the changes and try running this app on my device, but I got a 401 Authentication error on 1st run only. After that app runs fine as it should be.

screen.mp4

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
  • Any dependent changes have been merged
  • I have written Kotlin Docs whenever is applicable

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@epicadk
Copy link
Member

epicadk commented Dec 10, 2021

keep #1178

@epicadk epicadk closed this Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: Migrate SharedPreferences to DataStore
2 participants