fix(material/slider): change color of inactive track #29825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
change color of inactive track to pass 3:1 non text color contrast ratio fixes b/286300099
DBowen33
requested review from
crisbeto and
mmalerba
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change color and remove the opacity of inactive track to pass 3:1 non text color contrast ratio.
https://screenshot.googleplex.com/9xZQAkEaEjY2Ad4
BEFORE:
foreground: #E1E3E13d
background: #faf9fd
ratio: 1.04:1
AFTER:
foreground: #74777f
background: #faf9fd
ratio: 4.27:1
NOTE: This is a significant design change, so curious to see what y'all think of this
fixes b/286300099