Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nightly CI for installation user stories #193

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

rhelmot
Copy link
Member

@rhelmot rhelmot commented Sep 18, 2024

Fish wanted CI for angr/angr#4857 but it's not something we can test without a separate installation pass, so I put it here.

@rhelmot rhelmot force-pushed the feat/telemetry branch 4 times, most recently from 7f2da27 to 3eba7a2 Compare September 18, 2024 23:47
@twizmwazin
Copy link
Member

I don’t know exactly how opentelemetry works, but would it not be possible to install the dependency in the CI, activate it at the start of a specific test, and then retrieve the output to validate at the end of the test?

@ltfish
Copy link
Member

ltfish commented Sep 19, 2024

@twizmwazin We would like to test that OpenTelemetry is not installed and not required unless the user opts in. This gives our users the confidence that we do not collect any information by default.

@rhelmot rhelmot force-pushed the feat/telemetry branch 2 times, most recently from d1d852f to 981211e Compare September 19, 2024 05:54
@twizmwazin
Copy link
Member

I see. Maybe an alternative is setting up an environment like with the windows/macos smoke tests and then only running the telemetry test there? Or better yet also add a no-telemetry test case that runs in the main CI to ensure that it doesn’t log anything by default, if that’s possible?

@rhelmot
Copy link
Member Author

rhelmot commented Sep 19, 2024

The no-telemetry test would be a bit superfluous since the code is being exercised constantly, and in order to connect "the other end" of the telemetry pipe we would need to install the dependency which triggers the telemetry to activate.

I would rather have this very under-specified environment (matrix-tested across platforms?) to test specific user stories for installations that we want to make sure work.

@rhelmot rhelmot merged commit 891fc86 into master Sep 19, 2024
@rhelmot rhelmot deleted the feat/telemetry branch September 19, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants