This repository has been archived by the owner on Apr 21, 2021. It is now read-only.
Added Fan Support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit ff8cb4a Author: gregorybutron <[email protected]> Date: Tue Sep 29 21:48:31 2020 +0800 cleaned up debug messages commit f4c5422 Author: gregorybutron <[email protected]> Date: Tue Sep 29 21:36:56 2020 +0800 Squashed commit of the following: commit e4fee69 Author: gregorybutron <[email protected]> Date: Tue Sep 29 20:15:12 2020 +0800 fixed command execution for fan speed commit f824d08 Author: gregorybutron <[email protected]> Date: Tue Sep 29 18:19:18 2020 +0800 added additional debugging info commit 00ebecb Author: gregorybutron <[email protected]> Date: Tue Sep 29 18:10:22 2020 +0800 updated fan speed mode state commit 2f82791 Author: gregorybutron <[email protected]> Date: Tue Sep 29 17:57:56 2020 +0800 updated fan speed mode commit f4a675f Author: gregorybutron <[email protected]> Date: Tue Sep 29 16:55:45 2020 +0800 fixing the fan speed percent commit f44ac9c Author: gregorybutron <[email protected]> Date: Thu Jul 16 23:20:23 2020 +0800 fixed fanspeed up commit 027568b Author: gregorybutron <[email protected]> Date: Thu Jul 9 19:43:07 2020 +0800 fixed up fan speed type defs commit 5f913a6 Author: gregorybutron <[email protected]> Date: Sat Jun 27 16:43:31 2020 +0800 added fanpseed mode and percent
This was referenced Sep 29, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Per issue 7: andrei-tatar/node-red-contrib-nora#7
We are adding fan support.
This adds support for fans with 4 speed modes, and percentage based fan speeds.
It does not support fans that are reversible.
It includes a node js test service that can be used to verify that fans are working.
I created a full test environment and verified that all google fan control commands were working as intended.
Depends on: andrei-tatar/nora-service#34