Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* valuables: step1: enhance syntax #1

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

aDuke1
Copy link

@aDuke1 aDuke1 commented Apr 30, 2015

No description provided.

@andreberg
Copy link
Owner

Is your fork of PoE-Item-Info current with the changes you wanted to contribute? If so, I think I am just going to checkout your repo from the command line, make a feature branch copy in my repo and then merge the changes for your feature contribution so I can play around and test things out in a separate branch on my local PC. Less work for you and more freedom for me :)

@aDuke1
Copy link
Author

aDuke1 commented May 1, 2015

Not sure what you mean with "current" in this context.
My fork was created 2 days ago and contains just one commit, merely a
first preliminary step for what I plan to change.

I'm not too familar with branching and merging. I'm used to creating
very small steps that are compatible with master (and thus can be tested
by those who run on bleeding edge).

btw which timezone do you live in ? I'm in UTC+1

Duke

Am 01.05.2015 um 17:26 schrieb André Berg:

Is your fork of PoE-Item-Info current with the changes you wanted to
contribute? If so, I think I am just going to checkout your repo from
the command line, make a feature branch copy in my repo and then merge
the changes for your feature contribution so I can play around and test
things out in a separate branch on my local PC. Less work for you and
more freedom for me :)


Reply to this email directly or view it on GitHub
#1 (comment).

@andreberg
Copy link
Owner

Ah, I see. Didn't realize that. Thought you had all the changes done. Ignore the pull request thing then. I'll write a reply to your email since it ties in with the question you asked there anyway. Oh and I'm UTC+1 as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants