Add test for hsl alpha in attribute/color #954
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: N/A
Description of changes:
Fixing attribute/color so that it work with hsl() colors that have an alpha channel.
The issue lies with tinycolor2 that does not recognise that syntax and fixes the alpha to 1 if hsl() is used. According to the CSS spec, you can specify a fourth argument, so both hsl and hsla should work.
Creating this PR as a draft and I will mark it as ready once bgrins/TinyColor#269 lands
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.