Fix redirect bug to /# that occurs on some browsers #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Amos,
Great work on the book, I learned a tremendous amount! I built out an app from the book and life was good. I checked back in about 6 weeks later on Chrome, and I came across the same bug described here: linnovate/mean#192, when trying to login with Google. It only happened on Chrome, and it became an issue only in the last 6 weeks as I had done all my development on Chrome. Anyways, I implemented the fix described in the issue successfully, and I think it would be really valuable to include it in your repo since you include a fix for the Facebook redirect anyways. This problem completely befuddled me for a couple of hours (everything was working in Firefox and Safari), and would be maddening for someone to debug when they are working through your book...
Thanks again for your work!