Skip to content

Commit

Permalink
Settings: Better Defaults (#1650)
Browse files Browse the repository at this point in the history
* Settings: Increase saturation multiplier

Reason: Because of inaccuracies of the network latency estimation algorithm which cause it to be more conservative

* Settings: Be more generous with FR

Reason: at the default values shimmering at the edges these values make it much least noticeable and still very functional for users with low-end hardware(people with higher end hardware can always just increase it if they want no shimmer

* Settings: Update saturation and change schema settings

Reason: Last value causes frames to get bunched up and it doesn't make sense to have one setting have a step size of 0.05
  • Loading branch information
Vixea authored Jun 1, 2023
1 parent bb559d1 commit bffaa44
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions alvr/session/src/settings.rs
Original file line number Diff line number Diff line change
Expand Up @@ -247,7 +247,7 @@ pub enum BitrateMode {
help = "Percentage of network bandwidth to allocate for video transmission"
))]
#[schema(flag = "real-time")]
#[schema(gui(slider(min = 0.5, max = 2.0, step = 0.05)))]
#[schema(gui(slider(min = 0.5, max = 5.0, step = 0.01)))]
saturation_multiplier: f32,

#[schema(strings(display_name = "Maximum bitrate"))]
Expand Down Expand Up @@ -916,7 +916,7 @@ pub fn session_settings_default() -> SettingsDefault {
mode: BitrateModeDefault {
ConstantMbps: 30,
Adaptive: BitrateModeAdaptiveDefault {
saturation_multiplier: 0.95,
saturation_multiplier: 1.0,
max_bitrate_mbps: SwitchDefault {
enabled: false,
content: 100,
Expand Down Expand Up @@ -1030,8 +1030,8 @@ pub fn session_settings_default() -> SettingsDefault {
foveated_rendering: SwitchDefault {
enabled: true,
content: FoveatedRenderingDescDefault {
center_size_x: 0.4,
center_size_y: 0.35,
center_size_x: 0.45,
center_size_y: 0.4,
center_shift_x: 0.4,
center_shift_y: 0.1,
edge_ratio_x: 4.,
Expand Down

0 comments on commit bffaa44

Please sign in to comment.