Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PageElement: Parse page numbers and page separators #59

Merged
merged 1 commit into from
Dec 21, 2023

Conversation

luoli830
Copy link
Contributor

@luoli830 luoli830 commented Dec 6, 2023

add PageElement and classify them before classified into TitleElement in title_classifier step

@luoli830 luoli830 requested a review from Elijas as a code owner December 6, 2023 18:01
@Elijas Elijas added the status:deferred Deferred for future consideration. label Dec 8, 2023
@Elijas
Copy link
Member

Elijas commented Dec 8, 2023

Thanks for the PR! We're working on the next generation of tests which will incorporate page number classification testing as well, so let's align the addition of this codebase until then.

Looking forward!

@Elijas Elijas merged commit 344c404 into alphanome-ai:main Dec 21, 2023
0 of 3 checks passed
@Elijas
Copy link
Member

Elijas commented Dec 21, 2023

Thank you for the contribution! 🎉
#56

@Elijas Elijas removed the status:deferred Deferred for future consideration. label Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants