Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore ActionCard state purely from fields #136

Merged
merged 2 commits into from
Oct 27, 2022

Conversation

haydenshively
Copy link
Member

Builds on #135

Copy link
Collaborator

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some initial comments

Copy link
Collaborator

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More comments

Base automatically changed from hs-operators to master October 27, 2022 17:38
@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for aloe-earn canceled.

Name Link
🔨 Latest commit 71a0d0b
🔍 Latest deploy log https://app.netlify.com/sites/aloe-earn/deploys/635afc00c768db0008c6efb5

@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for aloe-prime ready!

Name Link
🔨 Latest commit 71a0d0b
🔍 Latest deploy log https://app.netlify.com/sites/aloe-prime/deploys/635afc006476f300099c6767
😎 Deploy Preview https://deploy-preview-136--aloe-prime.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 27, 2022

Deploy Preview for aloe-blend-staging canceled.

Name Link
🔨 Latest commit 71a0d0b
🔍 Latest deploy log https://app.netlify.com/sites/aloe-blend-staging/deploys/635afc004916ac00083326f7

IanWoodard
IanWoodard previously approved these changes Oct 27, 2022
Copy link
Collaborator

@IanWoodard IanWoodard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approved (Fix comments please!)

@haydenshively haydenshively merged commit 6d417fc into master Oct 27, 2022
@haydenshively haydenshively deleted the hs-restore-from-fields branch October 27, 2022 21:49
haydenshively added a commit that referenced this pull request Nov 7, 2022
* Factoring out components that import tw macro (#97)

* Adding pre-commit, fixing linting issues (#105)

* Moving lending pair logic to lending pair. Fixing small bugs. (#102)

* Add auto refresh when user acks successful modal (#106)

* Adding logic to update the liquidation threshold (#108)

* Refactoring create margin account flow (#110)

* Factoring out Components, Stage 2 (#111)

* Adding gradient border and shadow to margin account card on hover (#121)

* Fixing font weight of range stepper input (#122)

* Updating ESLint (#120)
Co-authored-by: Hayden Shively <[email protected]>

* Fixing asterisk for prime (#124)

* Adding uniswap position tables (#126)
Co-authored-by: Hayden Shively <[email protected]>

* Additional linting for objects on single line (#128)

* Version 1 of a claim fees action card for uniswap positions (#127)

* Update Remove Liquidity Action description
Co-authored-by: Hayden Shively <[email protected]>

* Adding placeholder for lend pie chart (#117)
Co-authored-by: Hayden Shively <[email protected]>

* Move action-related logic + data models to their own folder (#131)

* Remove amounts from Uniswap Position data structure (#133)

* Restore ActionCard state purely from fields (#136)

* Make UI aware of whether user has already claimed fees for a Uni pos (#141)

* Polish various UI/UX stuff (#147)
Co-authored-by: Ian Woodard <[email protected]>

* Doing some post-refactor cleanup (#152)
Co-authored-by: Hayden Shively <[email protected]>

Co-authored-by: Aneesh Atri <[email protected]>
Co-authored-by: Ian Woodard <[email protected]>
Co-authored-by: Ian Woodard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants