Rewrite AddLiquidityActionCard #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for aloe-blend-staging canceled.
|
✅ Deploy Preview for aloe-prime ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✅ Deploy Preview for aloe-earn canceled.
|
haydenshively
force-pushed
the
hs-clean-uniswap-actions2
branch
from
8283399
to
8f4c310
Compare
IanWoodard
previously approved these changes
Oct 26, 2022
| amount1Str: fields?.at(1) ?? '', | ||
| lowerStr: fields?.at(2) ?? '', | ||
| upperStr: fields?.at(3) ?? '', | ||
| isToken0Selected: fields?.at(4) === 'true', |
There was a problem hiding this comment.
not a huge fan of using strings for this but understand the reasoning and the tradeoff
prime/src/components/borrow/actions/UniswapAddLiquidityActionCard.tsx
Outdated
Show resolved
Hide resolved
| setLocalToken0Amount(previousActionCardState.textFields[0]); | ||
| setLocalToken1Amount(previousActionCardState.textFields[1]); | ||
| if (lower != null && upper != null && currentTick != null) { | ||
| if (shouldAmount0InputBeDisabled(lower, upper, currentTick)) { |
There was a problem hiding this comment.
This is on me as I did this, but I think shouldAmount0InputBeDisabled and shouldAmount1InputBeDisabled should be in this file above this component as they aren't relevant to other actions and don't make sense to have for general Uniswap purposes. You don't need to move them, just pointing it out.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the live version, it's possible to make the tokenInputs spike to infinity and write "OUT OF BOUNDS" errors to the console. This rewrite fixes those issues (whatever they were) and substantially simplifies the code. Again, this is part of the broader refactor I'm working on.
When reviewing, there's really no point to looking at the diff. Better off seeing if it works in the deploy preview, and then just reading the new code in isolation.