'File partition' option and 'document' directory specification #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
undfined
approved these changes
Sep 30, 2024
src/deduper.rs
Outdated
Comment on lines
140
to
148
| docs_location.replace( | ||
| &format!( | ||
| "/{}/", | ||
| dedupe_config | ||
| .document_dir | ||
| .unwrap_or(String::from("documents")) | ||
| ), | ||
| &attr_prefix, | ||
| ) |
There was a problem hiding this comment.
Should we add a test for this?
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [project] | |||
| name = "dolma" | |||
| version = "1.0.14.post1" | |||
| version = "1.0.14.dev6" | |||
There was a problem hiding this comment.
Let's update the version and drop devN
undfined
reviewed
Oct 2, 2024
pyproject.toml
Outdated
| @@ -1,6 +1,6 @@ | |||
| [project] | |||
| name = "dolma" | |||
| version = "1.0.14.dev6" | |||
| version = "1.0.5" | |||
There was a problem hiding this comment.
No actually, when I started making dev branches I misread the version. The most recent not dev is 1.0.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for partitioning work at the file level - checking the hash of the de-globbed file names instead of spans. Also, creates an optional 'document dir' parameter for dealing with source data that doesn't have a 'document' directory to replace with 'attributes' (previously the attribute path generator would try replacing 'documents', not find any, and use the source directory!)