Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More trainer / launch improvements #32

Merged
merged 11 commits into from
Aug 30, 2024
Merged

More trainer / launch improvements #32

merged 11 commits into from
Aug 30, 2024

Conversation

epwalsh
Copy link
Member

@epwalsh epwalsh commented Aug 29, 2024

  • Fix how launch overrides arguments are passed to the entrypoint script.
  • Catch SIGTERM in the trainer and mark the run as canceled. This allows us to detect when a job is preempted in Beaker and save a checkpoint before the run is killed.
  • Always save the final checkpoint synchronously. That might be a little faster.

@epwalsh epwalsh merged commit 535722c into main Aug 30, 2024
14 checks passed
@epwalsh epwalsh deleted the epwalsh/doc-masking branch August 30, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant