-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support userInfiniteScroll use forcedLoadMore to keep requestin… #2640
Open
bbb169
wants to merge
2
commits into
alibaba:master
Choose a base branch
from
bbb169:feature/force-load-more
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
72 changes: 72 additions & 0 deletions
72
packages/hooks/src/useInfiniteScroll/demo/scrollForcedLoadMore.tsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,72 @@ | ||
import React, { useRef } from 'react'; | ||
import { useInfiniteScroll } from 'ahooks'; | ||
|
||
interface Result { | ||
list: string[]; | ||
nextId: string | undefined; | ||
lastId: string | undefined; | ||
} | ||
|
||
const resultData = ['0', '1', '2', '3', '4', '5', '6', '7', '8', '9', '10', '11', '12', '13']; | ||
|
||
setInterval(() => { | ||
resultData.push(resultData.length.toString()); | ||
}, 5000); | ||
|
||
function getLoadMoreList(lastId: string | undefined, limit: number): Promise<Result> { | ||
let start = -1; | ||
if (lastId) { | ||
start = resultData.findIndex((i) => i === lastId); | ||
} | ||
const end = start + limit; | ||
const list = resultData.slice(start + 1, end); | ||
const nId = resultData.length >= end ? resultData[end] : undefined; | ||
return new Promise((resolve) => { | ||
setTimeout(() => { | ||
resolve({ | ||
list, | ||
nextId: nId, | ||
lastId: list[list.length - 1] || lastId, | ||
}); | ||
}, 1000); | ||
}); | ||
} | ||
|
||
export default () => { | ||
const ref = useRef<HTMLDivElement>(null); | ||
|
||
const { data, loading, loadMore, loadingMore, noMore, trulyNoMore } = useInfiniteScroll( | ||
(d) => getLoadMoreList(d?.lastId, 4), | ||
{ | ||
target: ref, | ||
isNoMore: (d) => d?.nextId === undefined, | ||
forcedLoadMore: true, | ||
}, | ||
); | ||
|
||
return ( | ||
<div ref={ref} style={{ height: 150, overflow: 'auto', border: '1px solid', padding: 12 }}> | ||
{loading ? ( | ||
<p>loading</p> | ||
) : ( | ||
<div> | ||
{data?.list?.map((item) => ( | ||
<div key={item} style={{ padding: 12, border: '1px solid #f5f5f5' }}> | ||
item-{item} | ||
</div> | ||
))} | ||
</div> | ||
)} | ||
|
||
<div style={{ marginTop: 8 }}> | ||
{!noMore && ( | ||
<button type="button" onClick={loadMore} disabled={loadingMore}> | ||
{loadingMore ? 'Loading more...' : 'Click to load more'} | ||
</button> | ||
)} | ||
|
||
{trulyNoMore && <span>No more data</span>} | ||
</div> | ||
</div> | ||
); | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
我理解这个好像没那么复杂,不需要写很多复杂的逻辑,其他的逻辑都删掉,直接:
是不是就好了
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
会有问题的,当滚动到下方时,如果不判断
else if (scrollHeight - scrollTop <= clientHeight) { loadMore(true); }
会导致它一直触发loadMore,需要加一层判断来确认是用户主动向下滚动,而不是考虑threshold的距离There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
你又改 api 了呀,如果实现 forceLoadMore,从 api 的设计上 我认为在loadMore 的时候增加一个参数,是否忽略 noMore,比增加一个配置更好,逻辑处理也比较简单
你看看呢