IMP add an explicit notification message (printer name for example) #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bealdav
requested review from
florian-dacosta,
sebastienbeau,
hparfr and
Kev-Roche
hparfr
requested changes
Nov 6, 2024
| @@ -4,7 +4,11 @@ import {registry} from "@web/core/registry"; | |||
|
|
|||
| async function executeProxyAction({env, action}) { | |||
| action.action_list.map(function (act) { | |||
| env.services.notification.add(env._t("Your action is being executed"), { | |||
| let msg = "Your action is being executed"; | |||
| if (act.params.args && act.params.args[2] !== undefined) { | |||
There was a problem hiding this comment.
There is any problem to use args ?
There was a problem hiding this comment.
not really human readable / friendly
btw, why the !== check ? what values do you expect if act.params.args[2] is "" or false ?
|
Thanks for the review @hparfr . @mourad-ehm could you fix it ? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@bealdav
display an explicit message to facilitate debugging