Bump bumpalo from 3.11.0 to 3.12.0 (#2) #6
Annotations
12 warnings
call to `reserve` immediately after creation:
src/io/obj_file.rs#L41
warning: call to `reserve` immediately after creation
--> src/io/obj_file.rs:41:17
|
41 | / let mut result = vec![];
42 | | result.reserve(size);
| |_____________________________________^ help: consider using `Vec::with_capacity(/* Space hint */)`: `let mut result = Vec::with_capacity(size);`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#reserve_after_initialization
= note: `#[warn(clippy::reserve_after_initialization)]` on by default
|
parameter is only used in recursion:
src/complex_structures/bvh.rs#L108
warning: parameter is only used in recursion
--> src/complex_structures/bvh.rs:108:9
|
108 | max_primitives_in_node: usize,
| ^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_max_primitives_in_node`
|
note: parameter used here
--> src/complex_structures/bvh.rs:211:51
|
211 | let left = self.recursive_build(info, max_primitives_in_node, objects, start, mid);
| ^^^^^^^^^^^^^^^^^^^^^^
212 | let right = self.recursive_build(info, max_primitives_in_node, objects, mid, end);
| ^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion
= note: `#[warn(clippy::only_used_in_recursion)]` on by default
|
casting to the same type is unnecessary (`usize` -> `usize`):
src/complex_structures/bvh.rs#L230
warning: casting to the same type is unnecessary (`usize` -> `usize`)
--> src/complex_structures/bvh.rs:230:17
|
230 | index as usize
| ^^^^^^^^^^^^^^ help: try: `index`
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast
= note: `#[warn(clippy::unnecessary_cast)]` on by default
|
associated function `from_obj_file` is never used:
src/ray_tracer/scene.rs#L62
warning: associated function `from_obj_file` is never used
--> src/ray_tracer/scene.rs:62:19
|
53 | impl Scene {
| ---------- associated function in this implementation
...
62 | pub(crate) fn from_obj_file(path: PathBuf, t: Tracing) -> anyhow::Result<Scene> {
| ^^^^^^^^^^^^^
|
associated function `from_obj_file` is never used:
src/ray_tracer/scene.rs#L21
warning: associated function `from_obj_file` is never used
--> src/ray_tracer/scene.rs:21:19
|
16 | impl LinearTracer {
| ----------------- associated function in this implementation
...
21 | pub(crate) fn from_obj_file(path: PathBuf) -> anyhow::Result<(LinearTracer, Vec<Material>)> {
| ^^^^^^^^^^^^^
|
field `optical_density` is never read:
src/ray_tracer/material.rs#L9
warning: field `optical_density` is never read
--> src/ray_tracer/material.rs:9:16
|
3 | pub(crate) struct Material {
| -------- field in this struct
...
9 | pub(crate) optical_density: f64,
| ^^^^^^^^^^^^^^^
|
associated function `from_obj_file` is never used:
src/complex_structures/bvh.rs#L71
warning: associated function `from_obj_file` is never used
--> src/complex_structures/bvh.rs:71:19
|
70 | impl BVHTree {
| ------------ associated function in this implementation
71 | pub(crate) fn from_obj_file(path: PathBuf) -> anyhow::Result<(BVHTree, Vec<Material>)> {
| ^^^^^^^^^^^^^
|
method `inverse` is never used:
src/basic_geometry/vector.rs#L45
warning: method `inverse` is never used
--> src/basic_geometry/vector.rs:45:19
|
16 | impl Vector {
| ----------- method in this implementation
...
45 | pub(crate) fn inverse(&self) -> Vector {
| ^^^^^^^
|
variant `Scale` is never constructed:
src/basic_geometry.rs#L52
warning: variant `Scale` is never constructed
--> src/basic_geometry.rs:52:5
|
49 | pub(crate) enum Transformation {
| -------------- variant in this enum
...
52 | Scale(Vector),
| ^^^^^
|
= note: `Transformation` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis
= note: `#[warn(dead_code)]` on by default
|
unused imports: `Axis`, `Transform`:
src/main.rs#L15
warning: unused imports: `Axis`, `Transform`
--> src/main.rs:15:22
|
15 | use basic_geometry::{Axis, Transform};
| ^^^^ ^^^^^^^^^
|
= note: `#[warn(unused_imports)]` on by default
|
build
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions-rs/clippy-check@v1. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions-rs/clippy-check@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|