-
Notifications
You must be signed in to change notification settings - Fork 26.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update react/README.md #2451
base: master
Are you sure you want to change the base?
Update react/README.md #2451
Conversation
Fix jsx display issue in webpage https://airbnb.io/javascript/react/#quotes Fixes airbnb#2301
This comment has been minimized.
This comment has been minimized.
I see the issue you’re referencing. Can you link to something that describes how this fixes it? This doesn’t fix it for all the other cases of self-closing elements in the page; is there a more holistic solution? |
@ljharb Here's the output for the fix - |
@devtmk i'm confused; https://devtmk.github.io/javascript/react/#quotes has different JSX than https://airbnb.io/javascript/react/#quotes. There's also highlighting issues here: and probably a number of other places. It'd be great to figure out a way to fix them all at once, without requiring inline annotations. |
@DetrojaRadhey i commented on the PR with how that doesn't fix it; but also, please don't post a duplicate PR. In the future, post a link to your changes and a maintainer can pull them in. |
Fix jsx display issue in webpage
https://airbnb.io/javascript/react/#quotes
Fixes #2301