AIP-121: List responses contain the resource #1436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AIP-132 documents the guidance for List responses, which *contain* the resource as a `repeated` field, along with pagination information. This patch updates AIP-121 to consistently indicate that the List request merely contains the resource rather than being the resource, which wouldn't make sense since the point of a List request is to enumerate multiple such resources.
noahdietz
approved these changes
Oct 28, 2024
|
Good catch, thank you |
|
Thanks for the quick review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AIP-132 documents the guidance for List responses, which contain the resource as a
repeatedfield, along with pagination information. This patch updates AIP-121 to consistently indicate that the List request merely contains the resource rather than being the resource, which wouldn't make sense since the point of a List request is to enumerate multiple such resources.wchargin-branch: list-contains