Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link #1429

Merged
merged 1 commit into from
Oct 10, 2024
Merged

Fix broken link #1429

merged 1 commit into from
Oct 10, 2024

Conversation

paladin-devops
Copy link
Contributor

This commit fixes a link to AIP-202 in the documentation for AIP-129.

@paladin-devops paladin-devops requested a review from a team as a code owner October 9, 2024 15:55
Copy link

google-cla bot commented Oct 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Copy link
Collaborator

@noahdietz noahdietz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@noahdietz
Copy link
Collaborator

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Hi @paladin-devops you will need to resolve this for the change to be accepted :) If you'd rather not, lmk, and I can send a PR to fix this broken link as well and credit you

@paladin-devops
Copy link
Contributor Author

@noahdietz thank you for reaching out! I would appreciate if you could PR this fix. 🙏🏻

I signed the CLA, but it seems that since I'm using my GitHub noreply email address (83741749+paladin-devops​@users.noreply.github.com) for commit signing, which here says that won't work with the CLA.

You may have Keep my email address private enabled. Without a visible email address, the CLA cannot be checked. Uncheck it and re-create the offending commit, or have your CLA point of contact add your @users.noreply.github.com address to the CLA group.

@noahdietz noahdietz merged commit 082e4d1 into aip-dev:master Oct 10, 2024
2 checks passed
@noahdietz
Copy link
Collaborator

Done! Thanks I was able to manually verify your CLA signing and approve the contribution.

Then I promptly mixed up the number of the AIP being changed in the squashed commit - oops!

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants