XspectraCrystalWorkChain: Fix Input Bugs
#1047
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two bugs in the input steps of the `XspectraCrystalWorkChain`: * `WorkChain`s except when using `xch_smear` because the step to remove instances of `starting_magnetization(` was `pop`ing keys from the dictionary which it was looping over. * The `abs_atom_marker` input was not being passed to `get_xspectra_structures` correctly due to a typo.
|
Hi @superstar54. All good to go here. Unfortunately this does mean that the AiiDALab-QE XAS App will still have this issue until AiiDA-QE is updated for the QEApp. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1046
Fixes two bugs in the input steps of the
XspectraCrystalWorkChain:WorkChains except when usingxch_smearbecause the step to remove instances ofstarting_magnetization(waspoping keys from the dictionary which it was looping over.abs_atom_markerinput was not being passed toget_xspectra_structurescorrectly due to a typo.