Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD: eslint configurations #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

MrSlimCoder
Copy link

Hello :)
I have added eslint configurations for this project it can be usefull in development . what is your thought on that ?

@MrSlimCoder
Copy link
Author

Hey! also added eslint security rules 🏂🤞

@@ -0,0 +1,32 @@
{
"env": {
"browser": true,
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why bowser?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is default eslint config :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is default eslint config :

Copy link
Owner

@ahmadawais ahmadawais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd to have this but this is not working with the current prettier config I have. They both should format the code in the same way.

@MrSlimCoder
Copy link
Author

I'd to have this but this is not working with the current prettier config I have. They both should format the code in the same way.

Yup! it can make impact to your prettier config 🤹

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants