Determinant and Adjugate Matrix #1165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
October 30, 2024 14:43
felixwellen
reviewed
Oct 31, 2024
dist-newstyle/cache/compiler
Outdated
There was a problem hiding this comment.
This looks like accidentally committed files
There was a problem hiding this comment.
Yes. I have removed it.
|
Thanks for opening a PR on this! Determinants would certainly be very useful to have. |
felixwellen
reviewed
Oct 31, 2024
| @@ -0,0 +1,194 @@ | |||
| {-# OPTIONS --cubical #-} | |||
|
|
|||
| module Minor where | |||
There was a problem hiding this comment.
Module names should always be fully qualified, i.e. Cubical.Algebra.Determinant.Minor in this case.
There was a problem hiding this comment.
Thank you! I have fixed it.
added 2 commits
October 31, 2024 13:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the four new files, the determinant of a matrix over a commutative ring is introduced through Laplace expansion, and it is proven that the adjugate matrix multiplied by the matrix itself equals the determinant times the identity matrix.
Additionally, it is shown that the determinant is independent of the row or column chosen for expansion, along with a few other minor properties of the determinant.
I am happy to consider any improvements.