AG-13294 add sparklines migrations #93
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eliasmalik
reviewed
Nov 14, 2024
packages/cli/src/codemods/transforms/migrate-sparklines-options/babel-utils.ts
Outdated
Show resolved
Hide resolved
| } | ||
| } | ||
|
|
||
| const column = { |
There was a problem hiding this comment.
It seems we are changing every possible object in a codebase that contains a sparklineOptions object also if we are not sure it is passed to the grid?
This doesn't seem correct as we might change objects and code that has nothing to do with ag-grid
Would be good to see a test with react to see if it works with react properties too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.