FMWK-291 Set wasNull flag in ResultSet

aerospike · Dec 17, 2023 · 1fc757f · 1fc757f
1 parent 957e194
commit 1fc757f
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 6 deletions.
diff --git a/src/main/java/com/aerospike/jdbc/sql/AerospikeRecordResultSet.java b/src/main/java/com/aerospike/jdbc/sql/AerospikeRecordResultSet.java
@@ -43,19 +43,27 @@ protected boolean moveToNext() {
     @Override
     public Object getObject(String columnLabel) {
         logger.fine(() -> "getObject: " + columnLabel);
+        Object obj;
         if (columnLabel.equals(PRIMARY_KEY_COLUMN_NAME)) {
-            return getUserKey().map(Value::getObject).orElse(null);
+            obj = getUserKey().map(Value::getObject).orElse(null);
+        } else {
+            obj = getBin(columnLabel).orElse(null);
         }
-        return getBin(columnLabel).orElse(null);
+        wasNull = obj == null;
+        return obj;
     }
 
     @Override
     public String getString(String columnLabel) {
         logger.fine(() -> "getString: " + columnLabel);
+        String str;
         if (columnLabel.equals(PRIMARY_KEY_COLUMN_NAME)) {
-            return getUserKey().map(Value::toString).orElse(null);
+            str = getUserKey().map(Value::toString).orElse(null);
+        } else {
+            str = getBin(columnLabel).map(Object::toString).orElse(null);
         }
-        return getBin(columnLabel).map(Object::toString).orElse(null);
+        wasNull = str == null;
+        return str;
     }
 
     @Override

diff --git a/src/main/java/com/aerospike/jdbc/sql/BaseResultSet.java b/src/main/java/com/aerospike/jdbc/sql/BaseResultSet.java
@@ -24,9 +24,10 @@ public abstract class BaseResultSet<T> implements ResultSet,
     protected final List<DataColumn> columns;
     private final Statement statement;
     private final ResultSetMetaData metadata;
-    protected volatile int index;
+
+    protected int index;
     protected boolean afterLast;
-    private boolean wasNull;
+    protected boolean wasNull;
     private volatile boolean closed;
 
     protected BaseResultSet(Statement statement, String schema, String table, List<DataColumn> columns) {