-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH]check for algorithm_type #2339
Conversation
Thank you for contributing to
|
@MatthewMiddlehurst should I raise errors for the absence of the |
no, they do not have to have them, but if a classifier does have this tag, it should be one of thats all you need to check, thanks for your contributions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
aeon/testing/estimator_checking/_yield_classification_checks.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
Reference Issues/PRs
Fixes #1952
What does this implement/fix? Explain your changes.
Adds a check for
algorithm_type
inaeon.testing.estimator_checking._yield_classification_checks.py
For all contributions