-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MNT] Tidy up classification and regression tests #2314
base: main
Are you sure you want to change the base?
Conversation
Thank you for contributing to
|
@@ -1154,6 +1154,10 @@ def temporal_importance_curves( | |||
curves : list of np.ndarray | |||
The temporal importance curves for each feature. | |||
""" | |||
if is_regressor(self): | |||
raise NotImplementedError( | |||
"Temporal importance curves are not available for regression." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this covered in the tests? Would be good to increase the coverage on this class, its currently on 69% with 190 missed lines
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pr is the first step for doing this really, now that all the regressors are properly covered in general testing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tidies up the general testing checks for classification and regression.
This includes adding new tests to regression which were in classification previously, but did not have a regression variation.
Expands on the
interval_based
tests for both, and consolidates them into fewer files.