Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MNT] Tidy up classification and regression tests #2314

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

MatthewMiddlehurst
Copy link
Member

@MatthewMiddlehurst MatthewMiddlehurst commented Nov 6, 2024

Tidies up the general testing checks for classification and regression.
This includes adding new tests to regression which were in classification previously, but did not have a regression variation.
Expands on the interval_based tests for both, and consolidates them into fewer files.

@MatthewMiddlehurst MatthewMiddlehurst added classification Classification package regression Regression package testing Testing related issue or pull request labels Nov 6, 2024
@aeon-actions-bot aeon-actions-bot bot added the maintenance Continuous integration, unit testing & package distribution label Nov 6, 2024
@aeon-actions-bot
Copy link
Contributor

aeon-actions-bot bot commented Nov 6, 2024

Thank you for contributing to aeon

I have added the following labels to this PR based on the title: [ $\color{#EC843A}{\textsf{maintenance}}$ ].
I would have added the following labels to this PR based on the changes made: [ $\color{#2C2F20}{\textsf{testing}}$ ], however some package labels are already present.

The Checks tab will show the status of our automated tests. You can click on individual test runs in the tab or "Details" in the panel below to see more information if there is a failure.

If our pre-commit code quality check fails, any trivial fixes will automatically be pushed to your PR unless it is a draft.

Don't hesitate to ask questions on the aeon Slack channel if you have any.

PR CI actions

These checkboxes will add labels to enable/disable CI functionality for this PR. This may not take effect immediately, and a new commit may be required to run the new configuration.

  • Run pre-commit checks for all files
  • Run mypy typecheck tests
  • Run all pytest tests and configurations
  • Run all notebook example tests
  • Run numba-disabled codecov tests
  • Stop automatic pre-commit fixes (always disabled for drafts)
  • Disable numba cache loading
  • Push an empty commit to re-run CI checks

@aeon-actions-bot aeon-actions-bot bot added full pytest actions Run the full pytest suite on a PR codecov actions Run the codecov action on a PR labels Nov 6, 2024
@MatthewMiddlehurst MatthewMiddlehurst marked this pull request as ready for review November 7, 2024 14:51
@@ -1154,6 +1154,10 @@ def temporal_importance_curves(
curves : list of np.ndarray
The temporal importance curves for each feature.
"""
if is_regressor(self):
raise NotImplementedError(
"Temporal importance curves are not available for regression."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this covered in the tests? Would be good to increase the coverage on this class, its currently on 69% with 190 missed lines

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pr is the first step for doing this really, now that all the regressors are properly covered in general testing.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
classification Classification package codecov actions Run the codecov action on a PR full pytest actions Run the full pytest suite on a PR maintenance Continuous integration, unit testing & package distribution regression Regression package testing Testing related issue or pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants