Feat: Persist 'Share as Image' options #1581
Conversation
|
|
||
| db.setSetting( | ||
| "share_as_image_preferences", | ||
| JSON.parse(JSON.stringify(state)), |
There was a problem hiding this comment.
Alternative to this was
| JSON.parse(JSON.stringify(state)), | |
| { | |
| post: { ...state.post }, | |
| comment: { ...state.comment }, | |
| } |
passing state directly, or using structuredClone didn't work either.
| @@ -0,0 +1,16 @@ | |||
| import { ShareAsImagePreferences } from "./ShareAsImagePreferences"; | |||
|
|
|||
| export const defaultPreferences: ShareAsImagePreferences = { | |||
There was a problem hiding this comment.
I'd like to have these in a separate file, as I intend to flip some of these values downstream
|
@aeharding also, currently one of the toggles is labelled "Include Post Text", which seems to be misleading. In case of image posts, this actually toggles the image within the screenshot Update: I've renamed it to "Include Post Content" |
|
Thanks for making this PR! I tried to run locally, but the image isn't appearing (Firefox). It working in main but I haven't investigated further. 
|
|
I tried opening the built docker version on Firefox and it seems to be working:
Update: it even works as expected when running with
|
|
@sharunkumar Can you try share as image on the post, not a comment? That is where it fails for me. |
I'll look into it in a bit |
| const [includePostDetails, setIncludePostDetails] = useState( | ||
| !("comment" in data), | ||
| ); |
There was a problem hiding this comment.
@aeharding I guess this was the cause of the issue, and its not browser dependent. I tried it in incognito window in edge and its reproducing
includePostDetails is currently false by default in my config
There was a problem hiding this comment.
I believe I have fixed the issue in my latest commit: c8af557 (#1581)
let me know if there's anything else
sharunkumar
force-pushed
the
persist-share-as-image-choices
branch
from
a273f68
to
c8af557
Compare
sharunkumar
force-pushed
the
persist-share-as-image-choices
branch
from
8c8ca26
to
7957aa0
Compare
Resolves #1547
All the toggle buttons would be persisted
In the case where the user hits the upper limit for parent comments, the setting would remember it and set all future shares to have all parent comments visible