Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Options to configure defaults on 'Share as Image' on comments #1547

Open
sharunkumar opened this issue Aug 1, 2024 · 5 comments · May be fixed by #1581
Open

Options to configure defaults on 'Share as Image' on comments #1547

sharunkumar opened this issue Aug 1, 2024 · 5 comments · May be fixed by #1581
Labels
enhancement New feature or request

Comments

@sharunkumar
Copy link
Contributor

For example, having the post visible by default and loading the full comment context

I could raise a pr for adding this in settings if this is good to go

@sharunkumar sharunkumar added the enhancement New feature or request label Aug 1, 2024
@aeharding
Copy link
Owner

This would be cool!

I think my only thought is for simplicity, why not persist the last user selected options?

@sharunkumar
Copy link
Contributor Author

why not persist the last user selected options?

that's something I have considered as well, I'm okay with either approach

we could have

[sharing options page]
remember previous selections: yes/no
(if yes, below options would be hidden)
always show post: yes/no
show full comment context: yes/no
... etc

@aeharding
Copy link
Owner

That's possible. Altho the settings is already growing a lot. Maybe start with persisting previous selections?

@sharunkumar
Copy link
Contributor Author

quick question about persisting use case though - how will loading the full comment context be implemented? since we select it based on parent comments count. this selection might not make sense to persist across actions, since each comment can have a varying number of parents

Screenshot_20240810_185037_Chrome

@aeharding
Copy link
Owner

Yeah, agreed.

@sharunkumar sharunkumar linked a pull request Aug 11, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants