Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Sync main from stage 7/22 #358

Merged
merged 3 commits into from
Jul 23, 2024
Merged

[Release] Sync main from stage 7/22 #358

merged 3 commits into from
Jul 23, 2024

Conversation

aishwaryamathuria
Copy link
Collaborator

@aishwaryamathuria aishwaryamathuria commented Jul 22, 2024 •
edited
Loading

aishwaryamathuria and others added 3 commits July 19, 2024 16:45
@aishwaryamathuria
Enable Configurable Prompt Text at Selector Tray Level in Interactivi…
3415f0a 
…ty Journey (#351)

Adding an option to configure a generate button with prompt that is configurable based on the selected option in the selector tray.
/drafts/mathuria/interactiveelems/demo/handoff/totebag/brightorb

Resolves: MWPW-147481
@suhjainadobe
[MWPW-154272]: Eager Loading only one image for each viewport (#352)
589f745 
when there is only 1 image authored in tablet and in desktop we are able to see the eagerload is seen rendered for when the page is not in that viewport

Resolves: [MWPW-154272]
@mirafedas
MWPW-147716: Disabled background scroll for filter dialog (#335)
5afa3c3 
Disabled body scroll for merch-sidenav web component used in the catalog filter (on small screens it gets opened in a modal).

The AEM PSI check fails because the merch-card JS execution time is too long (around 1,057 ms), so the TBT score is too low.
The change in the PR is related only to merch-sidenav, which is not a culprit of low TBT, thus we can merge it, and should address the TBT score of the merch-card in a separate PR.

Corresponding tacocat PR: https://git.corp.adobe.com/wcms/tacocat.js/pull/613
Corresponding mas PR: adobecom/mas#20

Resolves: [MWPW-147716](https://jira.corp.adobe.com/browse/MWPW-147716)

Test URLs:
Before: https://main--cc--adobecom.hlx.live/products/catalog?martech=off&georouting=off&mep=off
After: https://mwpw-147716-merch-sidenav-scroll-lock--cc--adobecom.hlx.live/products/animate/free-trial-download

Here is a page for testing for QA (remove the space, I added it to make the PSI check to ignore this link):
https://mwpw-147716-merch-sidenav-scroll-lock/ --cc--adobecom.hlx.live/products/catalog?martech=off&georouting=off&mep=off
@aishwaryamathuria aishwaryamathuria requested a review from a team as a code owner July 22, 2024 04:59
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 22, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 22, 2024

Page Scores Audits Google
/careers?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 85.71429% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.77%. Comparing base (02e4e42) to head (5afa3c3).
Report is 83 commits behind head on main.

Files Patch % Lines
creativecloud/scripts/utils.js 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #358      +/-   ##
==========================================
+ Coverage   86.69%   88.77%   +2.07%     
==========================================
  Files           9       18       +9     
  Lines         947     2387    +1440     
==========================================
+ Hits          821     2119    +1298     
- Misses        126      268     +142

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spadmasa
Copy link
Collaborator

Verified the below 2 jira in stage and details are updated in https://jira.corp.adobe.com/browse/MWPW-147481
https://jira.corp.adobe.com/browse/MWPW-154272
@Roycethan can you please confirm on this pr #335 in stage to get it merged to main
CC : @aishwaryamathuria @sigadamvenkata @salonijain3

@Roycethan
Copy link
Collaborator

Verified the below 2 jira in stage and details are updated in https://jira.corp.adobe.com/browse/MWPW-147481 https://jira.corp.adobe.com/browse/MWPW-154272 @Roycethan can you please confirm on this pr #335 in stage to get it merged to main CC : @aishwaryamathuria @sigadamvenkata @salonijain3

Checked on stage, plz proceed thanks

@spadmasa spadmasa added verified ready for main PR is ready to be merged to main branch and removed needs verification labels Jul 23, 2024
@salonijain3 salonijain3 merged commit ff2930c into main Jul 23, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhjainadobe suhjainadobe suhjainadobe approved these changes

@Ruchika4 Ruchika4 Ruchika4 approved these changes

@amitbikram amitbikram Awaiting requested review from amitbikram

@salonijain3 salonijain3 Awaiting requested review from salonijain3

@drashti1712 drashti1712 Awaiting requested review from drashti1712

@sanjayms01 sanjayms01 Awaiting requested review from sanjayms01

Assignees

@spadmasa spadmasa

Labels
ready for main PR is ready to be merged to main branch verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@aishwaryamathuria @codecov-commenter @spadmasa @Roycethan @Ruchika4 @suhjainadobe @salonijain3 @mirafedas