Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Release] Merge stage to main 7/18 #356

Merged
merged 3 commits into from
Jul 18, 2024
Merged

[Release] Merge stage to main 7/18 #356

merged 3 commits into from
Jul 18, 2024

Conversation

* 06-28-24 ivan create branch

* 07-10-24 daall test

* daall test remove

* revert daall in interactive-elem.js

* add loadStyles import

* css issue fixed, prod vs stage ax urls added

* stage env check fixes

* add charlimit 1024 to prompt input

* refactored env logic, moved style function to block logic
@salonijain3 salonijain3 requested a review from a team as a code owner July 18, 2024 03:42
Copy link

aem-code-sync bot commented Jul 18, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (02e4e42) to head (acb971d).
Report is 79 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #356      +/-   ##
==========================================
+ Coverage   86.69%   88.51%   +1.82%     
==========================================
  Files           9       18       +9     
  Lines         947     2377    +1430     
==========================================
+ Hits          821     2104    +1283     
- Misses        126      273     +147     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sanjayms01 sanjayms01 self-requested a review July 18, 2024 04:47
Copy link

aem-code-sync bot commented Jul 18, 2024

Page Scores Audits Google
/careers?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@salonijain3 salonijain3 merged commit b58f35b into main Jul 18, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants