Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Release] Sync main from stage 7/9 #349

Merged
merged 8 commits into from
Jul 11, 2024
Merged

[Release] Sync main from stage 7/9 #349

merged 8 commits into from
Jul 11, 2024

Conversation

salonijain3
Copy link
Collaborator

@salonijain3 salonijain3 commented Jul 9, 2024 •
edited
Loading

Ruchika4 and others added 3 commits June 27, 2024 16:45
@Ruchika4
MWPW-153428-Eager load marquee background image only for current brea…
6239daa 
…kpoint (#346)

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* Update utils.js

* fix lint issue

* Update utils.js

* Update utils.js

* fix lint issue

* Update utils.js

* handle single background image

* Update utils.js

* Update utils.js

* incorporate review comments
@npeltier @salonijain3
MWPW-148256 decorate catalog cards & some sidenav with analytics attr…
2cee646 
…ibutes (#343)

* MWPW-148256 decorate catalog page

* MWPW-148256 sort

* MWPW-148256 removing unit tests

to be moved later under functional tests eventually (unit test are really not trivial to setup)

* remove irregular whitespace

* MWPW-148256 attempt to proxy event

* MWPW-148256 defer to other tickets

* MWPW-148256 small update

---------

Co-authored-by: Saloni Jain <[email protected]>
@suhjainadobe
MWPW-153144 Pre-load Marquee image if the marquee is getting replaced…
c79a052 
… in MEP (#345)

Pre-load Marquee image if the marquee is getting replaced in MEP

Resolves: MWPW-153144

Test URLs:

Before: https://main--cc--adobecom.hlx.page/drafts/suhjain/personalization/document
After: https://eagerloadimg--cc--adobecom.hlx.live/drafts/suhjain/personalization/document?mep=off&martech=off
@salonijain3 salonijain3 requested a review from a team as a code owner July 9, 2024 17:16
@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 9, 2024 •
edited
Loading

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync AEM Code Sync
Copy link

aem-code-sync bot commented Jul 9, 2024 •
edited
Loading

Page Scores Audits Google
/careers?martech=off PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI

@rgclayton
Add path finder tool to sidekick. (#331)
2d96f65 
Add path finder tool to sidekick.

Adding path finder tool to sidekick.
Test URLs:

Before: https://main--cc--adobecom.hlx.live/careers?martech=off
After: https://rgclayton-path-finder--cc--adobecom.hlx.live/careers?martech=off
Added to Milo this week.

Access from any Word/Excel page.
Open sidekick
Click "path" button in sidekick (top level).
Launches the path tool.
Lists the relative (human readable) path for the Word/Excel doc.
Can modify the path to jump to a new Word/Excel doc.
Options include opening the path in same page or in a new tab
@sharath-kannan @salonijain3
fix(MWPW-152365):reading width increased. (#347)
eec8501 
* reading width increased

* Update styles.css

---------

Co-authored-by: Saloni Jain <[email protected]>
@suhjainadobe @salonijain3 @aishwaryamathuria
Update utils.js (#350)
427b2b2 
Co-authored-by: Saloni Jain <[email protected]>
Co-authored-by: Aishwarya Mathuria <[email protected]>
@sivasadobe @salonijain3
MWPW-140115 Release notes on slack channel when PR merged with Main b…
6ff279e 
…ranch (#348)

* feat(title-map): pr link mapped with title

* fix: package-lock.json added

---------

Co-authored-by: Saloni Jain <[email protected]>
@spadmasa
Copy link
Collaborator

spadmasa commented Jul 10, 2024 •
edited
Loading

Validation done on below prs in stage
#346
#345
#350
#347
#331

https://stage--cc--adobecom.hlx.live/products/photoshop
image
LCP seen improved from 4.6 s to 4.2s
image
image

https://stage--cc--adobecom.hlx.page/kr/creativecloud/roc/blog/design/create-instagram-highlight-cover
image

https://stage--cc--adobecom.hlx.live/drafts/Souj/html/marquee-variant1?martech=off&georouting=off
image

when updated to stage
https://github.com/adobecom/cc/tree/stage
https://adobe.sharepoint.com/:w:/r/sites/adobecom/_layouts/15/Doc.aspx?sourcedoc=%7BE3A36212-CE5F-4CED-BC68-B9E629B376DA%7D&file=creativecloud.docx&action=default&mobileredirect=true

image

image

@spadmasa
Copy link
Collaborator

@Roycethan can you please confirm on this pr in stage #343 if it can be merged to main
CC : @salonijain3 , @sigadamvenkata

@Roycethan
Copy link
Collaborator

@Roycethan can you please confirm on this pr in stage #343 if it can be merged to main CC : @salonijain3 , @sigadamvenkata

Yes plz @spadmasa I can see the changes in https://stage--cc--adobecom.hlx.live/products/catalog

@spadmasa spadmasa added verified ready for main PR is ready to be merged to main branch and removed needs verification labels Jul 11, 2024
@salonijain3 salonijain3 merged commit a994404 into main Jul 11, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suhjainadobe suhjainadobe suhjainadobe approved these changes

@aishwaryamathuria aishwaryamathuria aishwaryamathuria approved these changes

Assignees

@spadmasa spadmasa

Labels
ready for main PR is ready to be merged to main branch verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@salonijain3 @spadmasa @Roycethan @aishwaryamathuria @suhjainadobe @Ruchika4 @npeltier @rgclayton @sharath-kannan @sivasadobe