Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MWPW-160630] - Added new Article template UI #48

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

snowiewdev
Copy link

@snowiewdev snowiewdev commented Oct 15, 2024

Description

Added new Article page UI based on new design in Figma. Updates include:

  • Added in support for adding Page Template as sidebar in Metadata table, which will render new article layout with sidebar. Without this identifier, the UI would stay the same as the original article page with the full-width article header
  • Added article-hero-marquee block for the new article hero (split marquee)
    • users can custom background via passing in image, color, or circle-gradient(#hexcode1, #hexcode2) in table content directly
    • the block would automatically fetch article information (i.e. category link, article title & description) and display those as text, so that editors don’t need to re-enter information for the newly styled hero section
  • Added article-meta block for
    • loading the original full-width article header
    • loading the simplified version of author information & social sharing block for the updated article sidebar layout
    • putting the logic in the same block so that we can reuse the same styles on social sharing block & author information section
  • Added progress-bar block for better UI
  • Updated banner ui to support new design in Figma. The code is the same with the one under redesign/home branch
  • Updated recommended articles section with minor css updates in styles.css

Resolves

Test Urls

Article Page - with sidebar Page Template applied & new article-hero-marquee

Article Page - without sidebar identifier (keeps original article layout)

QA Tracking Sheet:

@snowiewdev snowiewdev self-assigned this Oct 15, 2024
Copy link

aem-code-sync bot commented Oct 15, 2024

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@snowiewdev snowiewdev changed the title [Pending Jira ticket creation] - Added new Article template UI [MWPW-160630] - Added new Article template UI Oct 17, 2024
@snowiewdev snowiewdev marked this pull request as ready for review October 17, 2024 20:47
@rgclayton
Copy link
Contributor

Hi @snowiewdev,

I noticed if I do not use the new header block on the page, the description from the metatadata is not populated, only the title is followed by page content.

Here's a sample page I created.
https://redesign-article--blog--adobecom.hlx.page/en/drafts/rclayton/article-with-video

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants