fix(dialog): fade-out animation when lazy loaded on popover overlays #4937
+86
−19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch previewReview the following VRT differencesWhen a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:
If the changes are expected, update the |
Lighthouse scores
What is this?Lighthouse scores comparing the documentation site built from the PR ("Branch") to that of the production documentation site ("Latest") and the build currently on Transfer Size
Request Count
|
Tachometer resultsChromecontextual-help permalinkbasic-test
dialog permalinkbasic-test
Firefoxcontextual-help permalinkbasic-test
dialog permalinkbasic-test
|
Pull Request Test Coverage Report for Build 11887314669Details
💛 - Coveralls |
Rajdeepc
requested changes
Nov 18, 2024
Rajdeepc
requested changes
Nov 18, 2024
| import { alertDestructive } from './dialog.stories.js'; | ||
| import { portrait } from './images.js'; | ||
| import { disabledButtonDecorator } from './index.js'; | ||
|
|
||
| const withOverlayDecorator = (story: () => TemplateResult): TemplateResult => { |
There was a problem hiding this comment.
This decorator needs to be initialized. This will create problems in VRT tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the moment of the
closeevent dispatch from theDialogBaseto happen after all the component is done animating. If the transition duration is 0, the event will dispatch instantly as before.Related issue(s)
Motivation and context
Using a
DialogBaseinside a lazy-loaded overlay content would not always allow for the fade-out animations to complete. Unsure why this issue happens only with the popover overlay, but this fix seems more in line with the documentation stating that the close event "announces that the dialog has been closed".How has this been tested?
Test case 1
Test case 2
Did it pass in Desktop?
Did it pass in Mobile?
Did it pass in iPad?
Screenshots (if appropriate)
Before:
before.mov
After:
after.mov
Types of changes
Checklist
Best practices
This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against
main.