Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: bump CSS tokens version #4921

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: bump CSS tokens version #4921

wants to merge 1 commit into from

Conversation

rubencarvalho
Copy link
Collaborator

Description

Related issue(s)

Motivation and context

How has this been tested?

  • Test case 1

    1. Go here
    2. Do this

  • Test case 2

    1. Go here
    2. Do this

  • Did it pass in Desktop?

  • Did it pass in Mobile?

  • Did it pass in iPad?

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • If my change required a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have reviewed at the Accessibility Practices for this feature, see: Aria Practices

Best practices

This repository uses conventional commit syntax for each commit message; note that the GitHub UI does not use this by default so be cautious when accepting suggested changes. Avoid the "Update branch" button on the pull request and opt instead for rebasing your branch against main.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Branch preview

Visual regression test results

When a visual regression test fails (or has previously failed while working on this branch), its results can be found in the following URLs:

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 11740778823

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.003%) to 98.191%
Totals Coverage Status
Change from base Build 11739806566: -0.003%
Covered Lines: 32314
Relevant Lines: 32732
💛 - Coveralls

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 8, 2024

Tachometer results

Chrome

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 740 kB 54.75ms - 56.43ms - faster ✔
1% - 5%
0.57ms - 2.64ms
branch 716 kB 56.60ms - 57.79ms slower ❌
1% - 5%
0.57ms - 2.64ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 960 kB 139.31ms - 142.50ms - faster ✔
5% - 8%
7.37ms - 11.66ms
branch 918 kB 148.98ms - 151.85ms slower ❌
5% - 8%
7.37ms - 11.66ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 69.80ms - 70.95ms - faster ✔
4% - 15%
2.90ms - 11.87ms
branch 875 kB 73.31ms - 82.20ms slower ❌
4% - 17%
2.90ms - 11.87ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 67.67ms - 72.77ms - faster ✔
2% - 9%
1.22ms - 6.56ms
branch 874 kB 73.30ms - 74.93ms slower ❌
2% - 10%
1.22ms - 6.56ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1875.13ms - 1877.86ms - unsure 🔍
-0% - +0%
-1.34ms - +2.48ms
branch 1.05 MB 1874.59ms - 1877.27ms unsure 🔍
-0% - +0%
-2.48ms - +1.34ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1881.39ms - 1884.30ms - unsure 🔍
+0% - +0%
+0.36ms - +4.23ms
branch 1.05 MB 1879.27ms - 1881.83ms unsure 🔍
-0% - -0%
-4.23ms - -0.36ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 522.09ms - 526.65ms - faster ✔
0% - 2%
1.67ms - 9.63ms
branch 937 kB 526.75ms - 533.29ms slower ❌
0% - 2%
1.67ms - 9.63ms		 -

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 33.77ms - 35.35ms - faster ✔
12% - 17%
4.82ms - 6.99ms
branch 758 kB 39.72ms - 41.21ms slower ❌
14% - 21%
4.82ms - 6.99ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 41.97ms - 42.45ms - faster ✔
1% - 3%
0.57ms - 1.24ms
branch 958 kB 42.87ms - 43.35ms slower ❌
1% - 3%
0.57ms - 1.24ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 402.59ms - 408.11ms - faster ✔
1% - 3%
5.96ms - 14.61ms
branch 959 kB 412.31ms - 418.96ms slower ❌
1% - 4%
5.96ms - 14.61ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 54.55ms - 55.59ms - faster ✔
5% - 8%
2.82ms - 4.76ms
branch 899 kB 58.04ms - 59.68ms slower ❌
5% - 9%
2.82ms - 4.76ms		 -

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 661 kB 16.12ms - 16.67ms - unsure 🔍
-3% - +1%
-0.46ms - +0.15ms
branch 639 kB 16.42ms - 16.68ms unsure 🔍
-1% - +3%
-0.15ms - +0.46ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 211.40ms - 213.75ms - faster ✔
1% - 5%
2.66ms - 10.12ms
branch 717 kB 215.42ms - 222.50ms slower ❌
1% - 5%
2.66ms - 10.12ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 983 kB 432.67ms - 435.95ms - faster ✔
0% - 2%
1.68ms - 6.74ms
branch 940 kB 436.59ms - 440.44ms slower ❌
0% - 2%
1.68ms - 6.74ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 25.92ms - 26.45ms - faster ✔
6% - 10%
1.59ms - 2.94ms
branch 1.02 MB 27.83ms - 29.07ms slower ❌
6% - 11%
1.59ms - 2.94ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 351.75ms - 365.59ms - faster ✔
0% - 4%
0.92ms - 15.16ms
branch 1.01 MB 365.05ms - 368.37ms slower ❌
0% - 4%
0.92ms - 15.16ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 44.26ms - 45.09ms - faster ✔
6% - 8%
2.84ms - 4.08ms
branch 806 kB 47.68ms - 48.60ms slower ❌
6% - 9%
2.84ms - 4.08ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 505.16ms - 511.90ms - faster ✔
2% - 4%
8.40ms - 18.75ms
branch 775 kB 518.18ms - 526.03ms slower ❌
2% - 4%
8.40ms - 18.75ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 106.55ms - 107.16ms - faster ✔
1% - 2%
1.22ms - 2.23ms
branch 775 kB 108.17ms - 108.99ms slower ❌
1% - 2%
1.22ms - 2.23ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 742 kB 77.78ms - 79.65ms - faster ✔
2% - 5%
1.62ms - 3.77ms
branch 718 kB 80.88ms - 81.95ms slower ❌
2% - 5%
1.62ms - 3.77ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 862 kB 35.40ms - 36.01ms - faster ✔
3% - 5%
0.92ms - 1.82ms
branch 828 kB 36.75ms - 37.40ms slower ❌
3% - 5%
0.92ms - 1.82ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 25.19ms - 25.74ms - faster ✔
7% - 10%
1.99ms - 2.85ms
branch 789 kB 27.55ms - 28.21ms slower ❌
8% - 11%
1.99ms - 2.85ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 957 kB 53.69ms - 54.63ms - faster ✔
5% - 7%
2.59ms - 4.05ms
branch 912 kB 56.92ms - 58.03ms slower ❌
5% - 8%
2.59ms - 4.05ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 43.58ms - 44.49ms - faster ✔
7% - 10%
3.26ms - 4.63ms
branch 887 kB 47.47ms - 48.49ms slower ❌
7% - 11%
3.26ms - 4.63ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 788 kB 62.02ms - 64.47ms - faster ✔
1% - 6%
0.96ms - 3.79ms
branch 762 kB 64.92ms - 66.32ms slower ❌
1% - 6%
0.96ms - 3.79ms		 -
Firefox

action-bar permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 740 kB 121.23ms - 129.01ms - unsure 🔍
-8% - +0%
-9.91ms - +0.43ms
branch 716 kB 126.46ms - 133.26ms unsure 🔍
-0% - +8%
-0.43ms - +9.91ms		 -

action-menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 960 kB 284.76ms - 286.88ms - faster ✔
15% - 16%
48.58ms - 53.82ms
branch 918 kB 334.62ms - 339.42ms slower ❌
17% - 19%
48.58ms - 53.82ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 917 kB 157.38ms - 160.82ms - slower ❌
6% - 12%
9.60ms - 17.04ms
branch 875 kB 142.49ms - 149.07ms faster ✔
6% - 11%
9.60ms - 17.04ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 916 kB 146.60ms - 150.60ms - slower ❌
1% - 5%
1.61ms - 7.19ms
branch 874 kB 142.26ms - 146.14ms faster ✔
1% - 5%
1.61ms - 7.19ms		 -

test-open-close-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1891.40ms - 1899.72ms - faster ✔
0% - 1%
5.07ms - 16.57ms
branch 1.05 MB 1902.41ms - 1910.35ms slower ❌
0% - 1%
5.07ms - 16.57ms		 -

test-open-close permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.09 MB 1897.09ms - 1900.55ms - unsure 🔍
-0% - -0%
-5.62ms - -0.30ms
branch 1.05 MB 1899.76ms - 1903.80ms unsure 🔍
+0% - +0%
+0.30ms - +5.62ms		 -

breadcrumbs permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 979 kB 838.43ms - 867.97ms - unsure 🔍
-2% - +1%
-20.09ms - +11.29ms
branch 937 kB 852.30ms - 862.90ms unsure 🔍
-1% - +2%
-11.29ms - +20.09ms		 -

card permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 67.23ms - 74.61ms - faster ✔
10% - 21%
7.76ms - 17.84ms
branch 758 kB 80.29ms - 87.15ms slower ❌
10% - 26%
7.76ms - 17.84ms		 -

combobox permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 73.51ms - 79.05ms - unsure 🔍
-0% - +8%
-0.11ms - +5.91ms
branch 958 kB 72.20ms - 74.56ms unsure 🔍
-8% - +0%
-5.91ms - +0.11ms		 -

light-dom-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1 MB 736.88ms - 761.44ms - slower ❌
4% - 8%
27.99ms - 56.89ms
branch 959 kB 699.10ms - 714.34ms faster ✔
4% - 8%
27.99ms - 56.89ms		 -

contextual-help permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 944 kB 113.96ms - 120.76ms - unsure 🔍
-4% - +3%
-4.75ms - +3.23ms
branch 899 kB 116.05ms - 120.19ms unsure 🔍
-3% - +4%
-3.23ms - +4.75ms		 -

illustrated-message permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 661 kB 31.30ms - 32.94ms - unsure 🔍
-1% - +4%
-0.46ms - +1.38ms
branch 639 kB 31.24ms - 32.08ms unsure 🔍
-4% - +1%
-1.38ms - +0.46ms		 -

menu permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 741 kB 402.25ms - 417.03ms - unsure 🔍
-6% - +0%
-24.48ms - +1.80ms
branch 717 kB 410.11ms - 431.85ms unsure 🔍
-0% - +6%
-1.80ms - +24.48ms		 -

overlay permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 664.27ms - 675.41ms - slower ❌
6% - 8%
35.88ms - 49.12ms
branch 1.02 MB 623.77ms - 630.91ms faster ✔
5% - 7%
35.88ms - 49.12ms		 -

directive-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.06 MB 52.60ms - 53.68ms - faster ✔
3% - 6%
1.53ms - 3.11ms
branch 1.02 MB 54.87ms - 56.05ms slower ❌
3% - 6%
1.53ms - 3.11ms		 -

element-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 1.05 MB 683.15ms - 693.77ms - slower ❌
5% - 10%
31.61ms - 60.31ms
branch 1.01 MB 629.17ms - 655.83ms faster ✔
5% - 9%
31.61ms - 60.31ms		 -

lazy-test permalink

Version Bytes Avg Time vs remote vs branch
npm latest 851 kB 100.80ms - 111.08ms - slower ❌
1% - 11%
0.72ms - 11.20ms
branch 806 kB 99.00ms - 100.96ms faster ✔
1% - 10%
0.72ms - 11.20ms		 -

picker permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 998.12ms - 1006.04ms - faster ✔
5% - 8%
47.88ms - 83.76ms
branch 775 kB 1050.40ms - 1085.40ms slower ❌
5% - 8%
47.88ms - 83.76ms		 -

popover permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 817 kB 149.72ms - 160.12ms - unsure 🔍
-6% - +2%
-9.24ms - +3.64ms
branch 775 kB 153.92ms - 161.52ms unsure 🔍
-2% - +6%
-3.64ms - +9.24ms		 -

slider permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 742 kB 162.32ms - 171.56ms - unsure 🔍
-6% - +1%
-9.65ms - +2.25ms
branch 718 kB 166.90ms - 174.38ms unsure 🔍
-1% - +6%
-2.25ms - +9.65ms		 -

tooltip permalink

test-basic

Version Bytes Avg Time vs remote vs branch
npm latest 956 kB 87.63ms - 94.73ms - slower ❌
12% - 23%
9.24ms - 17.60ms
branch 911 kB 75.56ms - 79.96ms faster ✔
11% - 19%
9.24ms - 17.60ms		 -

test-directive permalink

Version Bytes Avg Time vs remote vs branch
npm latest 831 kB 51.28ms - 53.00ms - faster ✔
1% - 5%
0.58ms - 2.74ms
branch 789 kB 53.14ms - 54.46ms slower ❌
1% - 5%
0.58ms - 2.74ms		 -

test-element permalink

Version Bytes Avg Time vs remote vs branch
npm latest 957 kB 147.59ms - 153.33ms - slower ❌
11% - 17%
14.87ms - 21.93ms
branch 912 kB 130.00ms - 134.12ms faster ✔
10% - 14%
14.87ms - 21.93ms		 -

test-lazy permalink

Version Bytes Avg Time vs remote vs branch
npm latest 932 kB 90.25ms - 93.03ms - faster ✔
23% - 29%
26.85ms - 37.67ms
branch 887 kB 118.67ms - 129.13ms slower ❌
29% - 41%
26.85ms - 37.67ms		 -

truncated permalink

basic-test

Version Bytes Avg Time vs remote vs branch
npm latest 788 kB 110.24ms - 116.36ms - faster ✔
0% - 9%
0.37ms - 11.27ms
branch 762 kB 114.61ms - 123.63ms slower ❌
0% - 10%
0.37ms - 11.27ms		 -

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rubencarvalho @coveralls