Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Simplify block creation #350 #351

Merged
merged 1 commit into from
May 22, 2024
Merged

feat: Simplify block creation #350 #351

merged 1 commit into from
May 22, 2024

Conversation

arumsey
Copy link
Collaborator

@arumsey arumsey commented May 16, 2024 •
edited
Loading

Please ensure your pull request adheres to the following guidelines:

  • make sure to link the related issues in this description
  • when merging / squashing, make sure the fixed issue references are visible in the commits, for easy compilation of release notes

Related Issues

Changes

  • add createBlock function
  • move metadata object creation to getMetadata function

Thanks for contributing!

@arumsey
feat: Simplify block creation adobe#350
75e85e6 
- add `createBlock` function
- move metadata object creation to `getMetadata` function
@arumsey arumsey mentioned this pull request May 16, 2024
Closed
10 tasks
kptdobe
kptdobe approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@kptdobe kptdobe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thanks @arumsey!

@kptdobe kptdobe merged commit b766954 into adobe:main May 22, 2024
2 checks passed
adobe-bot pushed a commit that referenced this pull request May 22, 2024
@semantic-release-bot
chore(release): 3.4.0 [skip ci]
bd1e39d 
# [3.4.0](v3.3.8...v3.4.0) (2024-05-22)

### Features

* simplify block creation [#350](#350) ([#351](#351)) ([b766954](b766954))
@adobe-bot
Copy link

🎉 This PR is included in version 3.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@arumsey arumsey deleted the create-block branch May 22, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kptdobe kptdobe kptdobe approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arumsey @adobe-bot @kptdobe