Eyedropper security #280
Merged
Eyedropper security #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalan-adobe
approved these changes
Oct 19, 2023
There was a problem hiding this comment.
Tested locally, looks good to me!
I would add a "reset" of UI element LOGO_SVG_SECURITY_MSG, force hidding it when starting a new eyedrop (otherwise, if message got displayed in previous run, clicking the Eyedrop button will not remove it).
We could add
LOGO_SVG_SECURITY_MSG.classList.add('hidden');
after line 222 in inspect.ui.js
github-actions bot
pushed a commit
that referenced
this pull request
Oct 19, 2023
# [1.47.0](v1.46.4...v1.47.0) (2023-10-19) ### Features * eyedropper security ([#280](#280)) ([ce4d964](ce4d964))
|
🎉 This PR is included in version 1.47.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #278 and #279
Security risk: the logo you have selected is an SVG. It may contain malicious code (like Javascript code). You can download it but you should inspect it before using it.