Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(mimir): update to 5.3.0 #1256

Merged
merged 4 commits into from
May 29, 2024
Merged

chore(mimir): update to 5.3.0 #1256

merged 4 commits into from
May 29, 2024

Conversation

eyenx
Copy link
Member

@eyenx eyenx commented May 28, 2024 •
edited
Loading

Description

Fixes #1248

Updates Grafana Mimir Helm Chart to 5.3.0 and Mimir to version 2.12.0

Mentionable Changes

Helm Chart

Rest are features, enhancements or bugfixes, https://github.com/grafana/mimir/blob/mimir-distributed-5.3.0/operations/helm/charts/mimir-distributed/CHANGELOG.md

Grafana Mimir

Rest are features, enhancements or bugfixes, https://github.com/grafana/mimir/blob/main/CHANGELOG.md

Checklist

  • This PR contains a description of the changes I'm making
  • I updated the version in Chart.yaml
  • I updated the changelog with an artifacthub.io/changes annotation in Chart.yaml, check the example in the documentation.
  • I updated applicable README.md files using pre-commit run
  • I documented any high-level concepts I'm introducing in docs/
  • CI is currently green and this is ready for review
  • I am ready to test changes after they are applied and released

@eyenx eyenx requested a review from a team as a code owner May 28, 2024 13:13
@eyenx eyenx requested review from hairmare and 4censord May 28, 2024 13:13
@github-actions github-actions bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 28, 2024
@hairmare
Copy link
Contributor

please add the changelog in Chart.yaml!

@github-actions github-actions bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 28, 2024
@eyenx
Copy link
Member Author

eyenx commented May 28, 2024

please add the changelog in Chart.yaml!

I did? Or do you want me to put every single PR I mention in there?

@eyenx eyenx requested review from hairmare and removed request for hairmare May 28, 2024 13:18
@hairmare
Copy link
Contributor

I did? Or do you want me to put every single PR I mention in there?

not when i posted the review ;)

some info on the actual changes would be nice... i usually try to summarise what i assume will have a downstream impact,

@eyenx eyenx marked this pull request as draft May 28, 2024 14:04
@eyenx
Copy link
Member Author

eyenx commented May 29, 2024

I did? Or do you want me to put every single PR I mention in there?

not when i posted the review ;)

some info on the actual changes would be nice... i usually try to summarise what i assume will have a downstream impact,

I pushed my stuff and then remembered shit, the changes in the Chart.yaml. Looks like we did it at the same time, you the review and I pushing the changes :) I will add some minimal breaking changes info

@eyenx eyenx requested review from hairmare and 4censord May 29, 2024 07:04
@eyenx eyenx marked this pull request as ready for review May 29, 2024 07:04
@eyenx eyenx merged commit 6f7ab04 into main May 29, 2024
3 checks passed
@eyenx eyenx deleted the feat/update-mimir branch May 29, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hairmare hairmare Awaiting requested review from hairmare

@4censord 4censord Awaiting requested review from 4censord

Assignees
No one assigned
Labels
size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version 5.4.0-weekly.291 of mimir is available!
3 participants
@eyenx @hairmare @4censord