-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: replace deprecated Accompanist Test Harness with official DeviceConfigurationOverride
#989
Open
SimonMarquis
wants to merge
4
commits into
main
Choose a base branch
from
test-harness-deprecation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimonMarquis
force-pushed
the
test-harness-deprecation
branch
from
February 21, 2024 13:40
121b91a
to
9af18c9
Compare
SimonMarquis
commented
Feb 21, 2024
gradle/libs.versions.toml
Outdated
@@ -59,7 +58,8 @@ androidx-compose-runtime-livedata = { module = "androidx.compose.runtime:runtime | |||
androidx-compose-ui = { module = "androidx.compose.ui:ui" } | |||
# https://developer.android.com/reference/kotlin/androidx/compose/ui/text/googlefonts/package-summary | |||
androidx-compose-ui-text = { module = "androidx.compose.ui:ui-text-google-fonts" } | |||
androidx-compose-ui-test = { module = "androidx.compose.ui:ui-test-junit4" } | |||
androidx-compose-ui-test = { module = "androidx.compose.ui:ui-test", version = "1.7.0-alpha02" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's wait for stable release, and remove this hardcoded version.
SimonMarquis
requested review from
soulcramer,
kazaky and
a team
as code owners
February 21, 2024 13:42
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint |
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint
|
soulcramer
force-pushed
the
test-harness-deprecation
branch
from
September 26, 2024 11:26
bb831cd
to
151f221
Compare
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: validation
|
Job Summary for Gradle👷 Build → 🧑🔬 Test → 🕵️ Lint :: build-test-lint
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs: https://google.github.io/accompanist/testharness/