Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix small inconsistencies in ExcitedStates #64

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mfherbst
Copy link
Member

@mfherbst mfherbst commented May 21, 2020

I think there are a few inconsistencies in ExcitedStates, for example that we only allow using the length gauge for the plot_spectrum. Also the plot_spectrum function is getting a bit messy. I'll try to correct this here.

Some questions to @maxscheurer:

  • What gauge is used for our rotatory strengths? Always velocity, right?
  • Also do you have a good reference (paper, textbook) for the rotatory strength calculation. I think we should probably add one in the code.

@mfherbst mfherbst marked this pull request as draft May 21, 2020 07:13
@maxscheurer
Copy link
Member

maxscheurer commented May 21, 2020

What gauge is used for our rotatory strengths? Always velocity, right?

Yes, in adcc we only use velocity gauge.

Also do you have a good reference (paper, textbook) for the rotatory strength calculation

We should ask @Drrehn, he's the expert. I guess it's somewhere in the Molecular Properties book?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants