Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the module name to the base name if ENV TF_ADD_MODULE_PATH is set. #95

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Adds the module name to the base name if ENV TF_ADD_MODULE_PATH is set. #95

wants to merge 6 commits into from

Conversation

cgroschupp
Copy link
Contributor

No description provided.

@cgroschupp
Copy link
Contributor Author

@adammck Can you take a look at it?

@mcanevet
Copy link

This PR works fine. Thanks for it.
I think it could be improve though. Currently, the modules' outputs are located in [all:vars] section even though, I think, it would be more logical to have them in [<module_name>:vars].
@cgroschupp what do you think?

@mcanevet
Copy link

Actually, I think we should have a [root.<module_name>:children] section with all root.<module_name>.<resource_name> in it so that we can have a [root.<module_name>:vars] section. With this kind of inventory, all modules' output would be added as variables of all resources declared in the module.

@cryptobioz cryptobioz mentioned this pull request Mar 20, 2019
Merged
@cgroschupp
Copy link
Contributor Author

@cryptobioz @mcanevet Thanks for the feedback.

@mcanevet
Copy link

@adammck would it be possible to merge this? IMHO it should even be the default behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cgroschupp @mcanevet @cryptobioz