Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support for scaleway v2 #135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

support for scaleway v2 #135

wants to merge 1 commit into from

Conversation

mwaaas
Copy link

@mwaaas mwaaas commented Dec 23, 2019

@adammck
Copy link
Owner

adammck commented Dec 23, 2019

Looks good, thank you! Could you please add an example to parser_test, so we don't accidentally break this in future?

@marco-m
Copy link

marco-m commented Jul 22, 2020

Hello @mwaaas , would you have time to follow up @adammck suggestion to add the tests, so that this PR can be merged? Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mwaaas @adammck @marco-m