Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shared-bindings/i2ctarget/I2CTarget.c: add finaliser #9810

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

shared-bindings/i2ctarget/I2CTarget.c: add finaliser #9810

wants to merge 3 commits into from
+27 −15

Conversation

dhalbert
Copy link
Collaborator

@dhalbert dhalbert commented Nov 14, 2024 •
edited
Loading

Tested with test mentioned in #9809.

EDIT: remove self type checks that were not needed. Add checks for deinit for safety. Similar checks are in other classes, such as I2C. Make fit on feather_m4_can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler Awaiting requested review from jepler

@caternuson caternuson Awaiting requested review from caternuson

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

I2CTarget not being deinited properly on soft restart
1 participant
@dhalbert