New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve _bleio.Connection.bind() doc, validation, and error messages #9732

Merged

tannewt merged 1 commit into adafruit:main from dhalbert:pair-improvements

Oct 21, 2024

Collaborator

dhalbert commented Oct 18, 2024

fixes some issues raised in BLE on the ESP32-S3 causes CircuitPython to hard fault under certain conditions #9708

Changes:

Note in documentation that _bleio.Connection.pair(bond=False) is not implemented, and validate that bond == True.
Print a better message on espressif and nordic when trying to pair when pairing is already in progress. Right now it prints "unknown ..." and gives a numeric error code.

dhalbert force-pushed the pair-improvements branch from ba9e4d5 to c3890a6 Compare

October 18, 2024 22:44


          improve _bleio.Connection.bind() doc, validation, and error messages

ac0904e

dhalbert force-pushed the pair-improvements branch from c3890a6 to ac0904e Compare

October 18, 2024 23:30

dhalbert requested review from tannewt and jepler

October 19, 2024 00:29

tannewt approved these changes

View reviewed changes

Member

tannewt left a comment

Thank you!

tannewt merged commit c50c795 into adafruit:main

562 checks passed

dhalbert deleted the pair-improvements branch

October 23, 2024 17:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet