Requests timeout #389
Merged
Requests timeout #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eout # Conflicts: # adabot/circuitpython_library_release.py
ladyada
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@ladyada
Supersedes #366.
Looking back through comments and PRs related to the very long-lasting and sometimes failing actions tasks I realized that #366 was never merged.
The default behavior for requests does not use a connect or read timeout and can hang forever if a requests fails in certain ways.
Trying to recall my mindset from the time #366 was submitted I think my theory was that when we see the task run for the very long period and still not succeed that it may have been getting stuck in one of these hang forever due to failed request cases. Explicitly setting timeout values for all requests calls should prevent that if it is indeed what is happening.
The other stuff from 366 is no longer relevant and was causing merge conflicts with the new way that release notes get generated by the adabot tool so I've just created a new branch and PR to get it brought up to date with the current main.
Hoping that this will resolve: #263. The issue occurs inconsistently and I've never been able to get it to occur outside of github actions so I'm not sure how to test other than trying and then watching the actions results for a while to see if we get any more ~6hr failure runs.